Great, it looks like that fixed it. I just sneakily dropped in the asm kernels on top of your branch, removed the old j2534.dll, successfully compiled, and successfully read and wrote my P01 with my MDI over J2534.
Tazzi picked that line 87 of j2534.cs contained a multiplication of 50 for the size of the buffer, when the size allocated is 4128 and should be sufficient as is. So I removed the *50 and rebuilt and it still works. Do you know why that *50 is there?
If anyone else wants to look in the hammer repo at the merge request from Joukoy and follow it to develop on his repo and let us know if they can test with success or fail I reckon we can merge this.
Thanks, Joukoy! If you want to pull J2534.dll out the project, and remove that *50, I think we can merge after a bit more testing. If without those changes on your side I'll fix it up afterwards, and then think about what comes next.
Maybe asm kernels. Linter is on the back of my mind, but thats going to break other outstanding branches and merges pretty hard. I am thinking solarlint with the config mentioned here:
https://dev.to/srmagura/c-linting-and-f ... n-2021-bna I gave it a test last year and it did what it said on the tin and had nice integration with VS, but I would like to get outstanding code in first, and that'll be a time sink of work and testing and cleaning up the rough edges.